Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:desktop toolbar custom style #519

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

q200892907
Copy link
Contributor

@q200892907 q200892907 commented Oct 7, 2023

Add a custom style to the desktop toolbar, including the shadow effect of the toolbar and the unselected color of the toolbar button

@q200892907
Copy link
Contributor Author

image

@LucasXu0 LucasXu0 force-pushed the feat-desktop_toolbar_style branch from 764edee to 4dcd3ff Compare October 10, 2023 07:54
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (af8d96b) 80.41% compared to head (4dcd3ff) 80.33%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   80.41%   80.33%   -0.09%     
==========================================
  Files         281      281              
  Lines       11863    11954      +91     
==========================================
+ Hits         9540     9603      +63     
- Misses       2323     2351      +28     
Files Coverage Δ
...b/src/editor/toolbar/desktop/floating_toolbar.dart 84.46% <100.00%> (+0.46%) ⬆️
...ditor/toolbar/desktop/floating_toolbar_widget.dart 97.14% <100.00%> (+0.26%) ⬆️
...lbar/desktop/items/bulleted_list_toolbar_item.dart 77.77% <100.00%> (ø)
...ktop/items/color/highlight_color_toolbar_item.dart 62.50% <100.00%> (ø)
...r/desktop/items/color/text_color_toolbar_item.dart 58.82% <100.00%> (ø)
...or/toolbar/desktop/items/format_toolbar_items.dart 95.65% <100.00%> (ø)
...r/toolbar/desktop/items/heading_toolbar_items.dart 80.76% <100.00%> (ø)
...editor/toolbar/desktop/items/icon_item_widget.dart 95.00% <100.00%> (ø)
.../toolbar/desktop/items/link/link_toolbar_item.dart 90.32% <100.00%> (ø)
...lbar/desktop/items/numbered_list_toolbar_item.dart 77.77% <100.00%> (ø)
... and 6 more

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 5155663 into AppFlowy-IO:main Oct 10, 2023
q200892907 added a commit to q200892907/appflowy-editor that referenced this pull request Oct 12, 2023
* main:
  fix: unable to clear the style by toggling twice (AppFlowy-IO#532)
  fix: pinyin IME on Linux (AppFlowy-IO#531)
  fix: background color issues (AppFlowy-IO#530)
  fix: cursor blink at wrong location when inserting text (AppFlowy-IO#529)
  feat: enable toggling and canceling of the formatting with shortcuts (AppFlowy-IO#528)
  chore: bump version 1.4.4 (AppFlowy-IO#527)
  fix: the selection handles remain on the screen after cutting the text (AppFlowy-IO#526)
  fix: the selection should be clear if header or footer is focusing (AppFlowy-IO#525)
  feat: customize desktop toolbar style (AppFlowy-IO#519)
  feat: add regex and case sensitive to `FindReplaceMenu` (AppFlowy-IO#480)
  feat: export JSON in mobile and update mobile_example.json (AppFlowy-IO#515)
  feat: support customizing error block (AppFlowy-IO#524)
  fix: impossible to click on any sub-items if the top level item is off-screen (AppFlowy-IO#522)
@q200892907 q200892907 deleted the feat-desktop_toolbar_style branch October 12, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants